⚠ In case you've missed it, we have migrated to our new website, with a brand new forum. For more details about the migration you can read our blog post for website migration. This is an archived forum. ⚠

  •     

profile picture

Close modal on save: what is this for?



dhyanan73

dhyanan73
  • profile picture
  • Member

Posted 15 March 2019 - 14:40 PM

Hi all,

can anyone explain what the "Close modal on save" checkbox at the bottom of the update and insertion forms is for, please?


dhyanan73

dhyanan73
  • profile picture
  • Member

Posted 18 March 2019 - 13:28 PM

In my experience this checkbox do nothing. Not even in the examples published on this website. Is it possible to delete/hide it to avoid confusion?


nunenthal

nunenthal
  • profile picture
  • Member

Posted 04 June 2019 - 08:42 AM

you can add this in your css to hide it.

 

.options-on-save
{
    opacity:0;
}


web-johnny

web-johnny
  • profile picture
  • Administrator
  • 1,166 posts

Posted 14 June 2019 - 12:36 PM

In my experience this checkbox do nothing. Not even in the examples published on this website. Is it possible to delete/hide it to avoid confusion?

 

Hello @dhyanan73

 

The functionality is basically to keep the modal on the save but it seems that it doesn't work anymore! It is something that I've missed. I will try to fix that for the next version and keep you updated once this is done.

 

I am sorry for the confusion that this may caused.

 

Regars

Johnny


dhyanan73

dhyanan73
  • profile picture
  • Member

Posted 14 June 2019 - 12:48 PM

I will try to fix that for the next version and keep you updated once this is done.

 

Hello @web-johnny, thanks for your answer.

Please also remember to enable the multilanguage for the caption text of the checkbox.

 

Regards,

Andrea


web-johnny

web-johnny
  • profile picture
  • Administrator
  • 1,166 posts

Posted 15 June 2019 - 06:46 AM

Hello @web-johnny, thanks for your answer.

Please also remember to enable the multilanguage for the caption text of the checkbox.

 

Regards,

Andrea

 

Hello Andrea,

 

The caption of the checkbox is in the translations. It is probably not translated in your language. You can go and change that at: application/libraries/GroceryCrudEnterprise/grocerycrud/enterprise/src/GroceryCrud/i18n/

For example if your language that you would like to translate it is Russian (just an example) then open the file: application/libraries/GroceryCrudEnterprise/grocerycrud/enterprise/src/GroceryCrud/i18n/Russian.php and search for: 'close_modal_on_save' string.

 

If they are lot of translations missing, then please also consider to share the new file with us if possible :)

Regards

Johnny


web-johnny

web-johnny
  • profile picture
  • Administrator
  • 1,166 posts

Posted 17 June 2019 - 07:04 AM

I would like to inform you that this is now scheduled for the next version. You can see the progress of the ticket from here: https://trello.com/c/djsmtzup/26-gc-398-checkbox-close-modal-on-save-doesnt-work-anymore by pressing the "Follow" button.

 

Thank you @dhyanan73 for reporting this

 

Regards

Johnny